Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Allow MSI version overide #11253

Closed
n1ght-hunter opened this issue Oct 7, 2024 · 2 comments · Fixed by #11388
Closed

[feat] Allow MSI version overide #11253

n1ght-hunter opened this issue Oct 7, 2024 · 2 comments · Fixed by #11388

Comments

@n1ght-hunter
Copy link

Describe the problem

When building a msi only version in the format of major.minor.patch.build numeric only.
this is pretty annoying as its not semvar and we use major.minor.patch-hash which doesn't work at all on with wix

Describe the solution you'd like

add a env overide to manually set the version for msi.
something like TAURI_MSI_VERSION this would allow people to not have to change there core version because of it

Alternatives considered

having to change the version on windows or not use msi

Additional context

let app_version = convert_version(settings.version_string())?;

@FabianLars
Copy link
Member

Would a platform specific config (https://v2.tauri.app/reference/config/#platform-specific-configuration) be enough or does the inner tauri app itself need the correct "normal" (non wix) version?

Not disagreeing with the feature request, just looking for a workaround until something is implemented.

@n1ght-hunter
Copy link
Author

i have setup a workaround for setting the version on windows but i do think it would make more sense to use a overide env since it is the only part of tauri that i know of that doesnt work with a semvar version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants