Merge branch 'dev' into refactor/tray-icon-event-tag-type

tauri-apps · Sep 26, 2024 · ee90884 · ee90884
2 parents 308af1d + 544328d
commit ee90884
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/bundler-nsis-webview2-success.md b/.changes/bundler-nsis-webview2-success.md
@@ -0,0 +1,5 @@
+---
+"tauri-bundler": "patch:bug"
+---
+
+Fix NSIS installer failing to determine whether webview installer downloaded correctly or not.
diff --git a/crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi b/crates/tauri-bundler/src/bundle/windows/nsis/installer.nsi
@@ -541,7 +541,7 @@ Section WebView2
         DetailPrint "$(webview2Downloading)"
         NSISdl::download "https://go.microsoft.com/fwlink/p/?LinkId=2124703" "$TEMP\MicrosoftEdgeWebview2Setup.exe"
         Pop $0
-        ${If} $0 = 0
+        ${If} $0 == "success"
           DetailPrint "$(webview2DownloadSuccess)"
         ${Else}
           DetailPrint "$(webview2DownloadError)"