feat(core): early panic if the PNG icon is not RGBA

tauri-apps · Apr 15, 2023 · cadfc51 · cadfc51
1 parent dfb5f52
commit cadfc51
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/.changes/early-panic-for-png-not-rgba.md b/.changes/early-panic-for-png-not-rgba.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch
+---
+
+Early panic if the PNG icon is not RGBA.
diff --git a/core/tauri-codegen/src/context.rs b/core/tauri-codegen/src/context.rs
@@ -516,6 +516,13 @@ fn png_icon<P: AsRef<Path>>(
   let mut reader = decoder
     .read_info()
     .unwrap_or_else(|e| panic!("failed to read icon {}: {}", path.display(), e));
+
+    let (color_type, _) = reader.output_color_type();
+
+    if color_type != png::ColorType::Rgba {
+      panic!("icon {} is not RGBA", path.display());
+    }
+
   let mut buffer: Vec<u8> = Vec::new();
   while let Ok(Some(row)) = reader.next_row() {
     buffer.extend(row.data());