-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus upgrade #314
Docusaurus upgrade #314
Conversation
✔️ Deploy Preview for tauri ready! 🔨 Explore the source changes: 0b1d0b7 🔍 Inspect the deploy log: https://app.netlify.com/sites/tauri/deploys/61ded9ae09e5710007e93224 😎 Browse the preview: https://deploy-preview-314--tauri.netlify.app |
I love updates. I use arch btw. |
Looks like it broke the release notes component. |
I had to set the node version using the |
I'll take a look at this tomorrow, should hopefully be a straightforward fix |
Thanks! |
I think some of the CSS is slightly modified as well, seems to be some extra padding around the body that makes it wider than 100%, will add that to the list. |
Ah finally the sidebar dropdowns are fast!!
According to facebook/docusaurus#5052 |
You're magic @probablykasper, just swapped that in place (after searching for hours this afternoon looking for anything around that change in release notes). Let's see how this latest commit does with the release notes. I kept getting some high CPU usage and hangs while it was pinging the API in Safari, but Edge seemed to work fine. Will see how it performs in Netlify |
docs sidebar doesn't exist on mobile. |
@amrbashir sidebar on mobile should now be fixed. Note that it's changed positions with the latest version of docusaurus so that it's with the rest of the navigation menu structure (a lot less confusing imo) Thoughts on this? |
Note that I had to add a dependancy on "@mdx-js/react" which allows for dynamic @ imports in JS from node modules. This should allow for easier automatic updates for any theme updates from docusaurus. I think this will let us remove a lot of older components in |
Over 100% width issue should now be fixed (caused by some hard-coded search bar CSS) |
Ideally we should make the search look like the Algolia component used in docusaurus site but that's for another PR. lets focus on fixing the overflow. |
@amrbashir I think that's just because nothing matches 'dx' (same happens on the current site). Searching for other things seems to be fine. |
@FabianLars actually, taking a closer look it seems like the whole nav bar on that side may need a bit of TLC |
I think what he meant was the layout breaking and the results not fully readable. At least it's ok on the website for now. (idk if it was like this before too). |
Ah, I see it now. I think the overall search bar experience may take some deeper digging then. 🦖 (docosaurus) changed how it works with the update, so just need to have a read through of the docs. The padding for the button itself should be fixed now. Added back in the beta badge and the locale dropdown (using the new 🦖-friendly elements) |
Let's merge this one then :) |
Upgrade all dependancies. Site needs to be reviewed to ensure all functionality is still as expected.
Motivation behind this is newer versions of Docusaurus provide better accessibility (plus, who doesn't like updates? /s )
The following changes were made to allow build:
I don't see any changes visually on the site with the above, but a review would be good in case I missed something.