fix(windows): Multi-monitor different scaling window size issue #858
Conversation
| }, | ||
| }); | ||
| result = ProcResult::Value(LRESULT(0)); | ||
| return; |
There was a problem hiding this comment.
There are more events pending below. Do we have to return early here?
There was a problem hiding this comment.
I found that the main issue is that the SetWindowPos function was called at the end, and the new parameters passed in caused the window to enlarge. I moved the return to this position mainly so that the ScaleFactorChanged event could trigger normally. Of course, moving it to the end to make the judgment and directly calling the SetWindowPos function with the correct parameters sounds like a more prudent approach.
I'm not good at English, sorry.
| // When the "Show window contents while dragging" is turned off, there is no need to adjust the window size. | ||
| if !is_show_window_contents_while_dragging_enabled() { | ||
| new_physical_inner_size = old_physical_inner_size; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this is look like better. @wusyong
|
Can you add a change file to explain what this PR does? |
|
Just a noted, when |
|
@wusyong Where do I need to add the description? In the |
|
See .changes. Basically you add a md file in that directory. |
|
@wusyong Thank you very much for the help, I've added a change file to the |
|
@xiaochen0517 I couldn't merge the PR because you have to sign your commits. |
… monitors with different scaling settings with the "Show window contents while dragging" option turned off in Windows.
xiaochen0517
force-pushed
the
fix/multi-monitor-scaling
branch
from
d5f863f to
73948bd
Compare
|
@wusyong Okay, I have added a sign to all my submits, thank you. |
|
This issue seems to have not been fixed and still exists when using the official version 2.0 |
|
@xiaochen0517 My system is Windows 11 and Show window contents while dragging is enabled |
When I was testing, if the option to show window contents while dragging was enabled, this issue did not occur. |
This pull request should only modify the tao project that Tauri 1.0 depends on, while Tauri 2.0 should depend on a different version. |
problem description：tauri-apps/tauri#6843 (comment)