feat(clipboard): Implement HTML and clear functionality #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clipboard clear Signed-off-by: TukanDev <[email protected]>
Signed-off-by: TukanDev <[email protected]>
amrbashir
requested changes
Feb 22, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Propagate error for clear as requested Co-authored-by: Amr Bashir <[email protected]>
Change to camelCase as requested Co-authored-by: Amr Bashir <[email protected]>
use camelCase here too Co-authored-by: Amr Bashir <[email protected]>
Revert back as mentioned in HTML PR
After discussion readHtml() is decided to be removed. Will follow and remove corresponding rust side function too.
…ort PR conversation Signed-off-by: TukanDev <[email protected]>
amrbashir
requested changes
Feb 24, 2024
Signed-off-by: TukanDev <[email protected]>
|
Looks like you need to run |
Signed-off-by: TukanDev <[email protected]>
amrbashir
reviewed
Feb 25, 2024
amrbashir
reviewed
Feb 25, 2024
fix ci calling Co-authored-by: Amr Bashir <[email protected]>
amrbashir
reviewed
Feb 25, 2024
Signed-off-by: TukanDev <[email protected]>
Signed-off-by: TukanDev <[email protected]>
amrbashir
previously approved these changes
Feb 25, 2024
amrbashir
previously approved these changes
Feb 25, 2024
amrbashir
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ability to set and read HTML to/from clipboard, including implementation to trigger clipboard clear.
Currently the added features are locked behind
#[cfg(desktop)]as i have no ability to test them for mobile targets.