-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deep-link): Add deep link support for desktop #916
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3d15bba
initial windows support
FabianLars 8b7467b
bundle type role for macos
FabianLars fc07cad
macos
FabianLars e30de3d
fix windows after macos changes
FabianLars ec54df1
linux
FabianLars 675a202
Merge remote-tracking branch 'origin/v2' into desktop-deep-links
FabianLars a2dd3df
Merge remote-tracking branch 'origin/v2' into desktop-deep-links
FabianLars bb6463a
update to beta (windows)
FabianLars c4fed8f
enable ci for deep link plugin
FabianLars 1b9bd19
linux
FabianLars 9ec7a77
android maybe?
FabianLars 6485034
linux
FabianLars e62d270
js api
FabianLars 419878e
readme
FabianLars f762106
android and permissions regen
FabianLars 37299b9
return true on unsupported platforms
FabianLars cf64d40
js api fix and docs
FabianLars e150e26
mobile for realsies
FabianLars fe6547f
dunce
FabianLars a91c67b
windows-registry
FabianLars 6d06de2
Merge remote-tracking branch 'origin/v2' into desktop-deep-links
FabianLars 89770d9
re-add -handler suffix
FabianLars 9ccd3d3
linux: fix is_registered
FabianLars bc9292b
linux: fix register and add unregister (both untested)
FabianLars 8c26e84
return add Error::Unsupported platform and fix docs
FabianLars 387bc49
fix docs again
FabianLars a0350cb
changed my mind, let's not add is_registered on macos for now
FabianLars c47d9d6
fix target_os cfgs
FabianLars 0882c36
merge from v2
lucasfernog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also mention that the URL will be passed as a CLI argument, and maybe showcase an example of using both plugins, maybe take https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app as inspiration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was to include the single-instance plugin on the website (the url param is mentioned)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would probably still make sense to include the example here as well so it can be found on npm and docs.rs as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm ok