-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fs/watch): migrate to notify-debouncer-full
#885
Conversation
Hi, thanks so much for contributing! Do you see any value in keeping the mini implementation around? Also, before you add more commits: And we'll also need a changefile like this one: https://github.com/tauri-apps/plugins-workspace/blob/v2/.changes/dialog-async-message-dialog.md, but it probably makes sense to wait for that in case we end up dropping the mini impl. |
let's just move to the full version and remove mini |
The full debouncer has more features, but is also more opinionated. Still, I think most people would prefer it. |
From what I can see Tauri is a full OS abstraction to most users. With that in mind I think you want the full debouncer. Debouncer-Mini is just a bare debouncer drop-in for when the old one got removed from notify. So it's for people who want nothing more than a thin abstraction on top and who can live with some surprising behaviour from the filesystem. Even more: You probably want more features than the full debouncer currently offers. Specifically filesystem detection and automatically choosing backends for paths. |
cb8a5c3
to
d6da17f
Compare
I updated the PR.
|
notify-debouncer-full
Thank you |
Thanks for merging, I'll create another PR for the track-file-ids feature then. |
Adds support for notify-debouncer-full
This complicates the API some more and I'm not super happy with it, yet. But at least this allows Tauri users to take advantage of the more involved
notify-debouncer-full
.Adds a watch section to the file system page of the demo app
I'm a contributor to the
notify
crate, on which the fs watcher is built. So if you have any questions or suggestions, please let me/the rest of the notify team know.One thing that I noticed is that Tauri might be the first application that really uses the event serialization. At least for me this feature has been more of an afterthought until now. I'm not happy with the way events are serialized, maybe we can change that - I'm thinking of using
#[serde(tag = "kind")]
for enums.