Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): export the missing Schedule class #874

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix(notification): export the missing Schedule class #874

merged 2 commits into from
Jan 3, 2024

Conversation

cijiugechu
Copy link
Contributor

close #625.

@cijiugechu cijiugechu requested a review from a team as a code owner January 3, 2024 11:20
@FabianLars
Copy link
Member

Awesome, thank you!
Since the constructor of Schedule is private i don't think we need to export ScheduleData right? I think that should stay an internal type. I'm open for discussion though if you disagree :)

FabianLars
FabianLars approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :)

@FabianLars FabianLars merged commit 1b1d795 into tauri-apps:v2 Jan 3, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 2, 2024
Merged
@cijiugechu cijiugechu deleted the fix-export-schedule branch January 3, 2024 15:57
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cijiugechu @FabianLars