-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to tauri beta, add permissions #862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
previously approved these changes
Jan 30, 2024
plugins/http/build.rs
Outdated
Comment on lines
28
to
34
// ensure scope entry is up to date | ||
let dummy = ScopeEntry { | ||
url: "https://tauri.app/*".into(), | ||
}; | ||
let _ = scope::Entry { | ||
url: dummy.url.parse().unwrap(), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to define an impl From<ScopeEntry> for scope::Entry
, no?
amrbashir
previously approved these changes
Jan 30, 2024
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@tauri-apps/[email protected], npm/@tauri-apps/[email protected], npm/[email protected] |
lucasfernog
previously approved these changes
Feb 3, 2024
lucasfernog
changed the title
[FS] V2 Allowlist Implementation
feat: update to tauri beta, add permissions
Feb 3, 2024
lucasfernog
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes related to the new Allowlist/ACL feature in Tauri 2.0 for the
Fs
plugin.These changes can be used by other plugins as examples to implement the new scoping/permission system.
The
tauri-plugin
crate needed for implementation of permission checks can be found in #8428It adds:
permissions/
folderbuild.rs
)TODO:
require_literal_leading_dot
as plugin configuration value