fix(deps): update rust crate tokio-tungstenite to 0.18 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/tokio-tungstenite-0.x
branch
from
bed0f99 to
b39186e
Compare
notriddle
added a commit
to notriddle/plugins-workspace
that referenced
this pull request
Dec 5, 2023
PolyMeilex/rfd#152 conflicts with the way tauri uses it. > Yeah, this is a decent solution, not much else we can do about this global state bs on C side. > > This will obviously blow up as soon as someone has other code that also uses GTK, but let's ignore that for now, as I want to get rid of GTK backend one day anyway (tauri-apps#66). Yes, Tauri is other code that also uses GTK, and it does, indeed, blow up. The best way around this is to stop using rfd entirely (they're planning to drop the GTK backend, which will probably break since the XDG Portal API doesn't cover message dialogs).
Merged
notriddle
added a commit
to notriddle/plugins-workspace
that referenced
this pull request
Dec 5, 2023
PolyMeilex/rfd#152 conflicts with the way tauri uses it. > Yeah, this is a decent solution, not much else we can do about this global state bs on C side. > > This will obviously blow up as soon as someone has other code that also uses GTK, but let's ignore that for now, as I want to get rid of GTK backend one day anyway (tauri-apps#66). Yes, Tauri is other code that also uses GTK, and it does, indeed, blow up. The best way around this is to stop using rfd entirely (they're planning to drop the GTK backend, which will probably break since the XDG Portal API doesn't cover message dialogs).
notriddle
added a commit
to notriddle/plugins-workspace
that referenced
this pull request
Dec 5, 2023
PolyMeilex/rfd#152 conflicts with the way tauri uses it. > Yeah, this is a decent solution, not much else we can do about this global state bs on C side. > > This will obviously blow up as soon as someone has other code that also uses GTK, but let's ignore that for now, as I want to get rid of GTK backend one day anyway (tauri-apps#66). Yes, Tauri is other code that also uses GTK, and it does, indeed, blow up. The best way around this is to stop using rfd entirely (they're planning to drop the GTK backend, which will probably break since the XDG Portal API doesn't cover message dialogs).
FabianLars
added a commit
that referenced
this pull request
Dec 5, 2023
* Do not use rfd 0.12.1 PolyMeilex/rfd#152 conflicts with the way tauri uses it. > Yeah, this is a decent solution, not much else we can do about this global state bs on C side. > > This will obviously blow up as soon as someone has other code that also uses GTK, but let's ignore that for now, as I want to get rid of GTK backend one day anyway (#66). Yes, Tauri is other code that also uses GTK, and it does, indeed, blow up. The best way around this is to stop using rfd entirely (they're planning to drop the GTK backend, which will probably break since the XDG Portal API doesn't cover message dialogs). * Update dialog-pin-rfd.md --------- Co-authored-by: Fabian-Lars <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.17->0.18Release Notes
snapview/tokio-tungstenite
v0.18.0Compare Source
tungstenitecore).v0.17.2Compare Source
Originheader case-sensitive (to keep compatibility with poorely-written servers that don't accept lowercaseOriginheader).WebSocketStreammore reasonable (returnNoneinstead of an error when the stream is normally closed).poll_close()works by properly driving the close of the stream till completion.v0.17.1Compare Source
tungstenitedependency (fixes a panic intungsteniteand MSRV), seetungstenite's changelog for more details.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.