Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs-js): fix writeBinaryFile invalid command usage #454

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

PretzelVector
Copy link
Contributor

writeBinaryFile always fails with Command write_binary_file not found. I am unaware of the history that caused this missing reference, but changing the command to write_file seemed to do the trick.

Only ad-hoc testing, but it worked for me™️

@PretzelVector PretzelVector requested a review from a team as a code owner June 24, 2023 01:09
@PretzelVector PretzelVector changed the title fix(fs): writeBinaryFile fails fix(fs): writeBinaryFile: Command write_binary_file not found Jun 24, 2023
amrbashir
amrbashir previously approved these changes Jun 26, 2023
@amrbashir
Copy link
Member

Could you please run pnpm i && pnpm --filter @tauri-apps/plugin-fs build to update the api-ffi.js file?

@amrbashir
Copy link
Member

looks like you have a commit that is not signed, could you please rebase the PR and sign all commits?

@amrbashir amrbashir changed the title fix(fs): writeBinaryFile: Command write_binary_file not found fix(fs-js): fix writeBinaryFile invalid command usage Jul 10, 2023
@amrbashir amrbashir merged commit 0bba693 into tauri-apps:v2 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants