Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): remove default notification sound on Windows #440

Merged
merged 1 commit into from
Jun 18, 2023
Merged

fix(notification): remove default notification sound on Windows #440

merged 1 commit into from
Jun 18, 2023

Conversation

amrbashir
Copy link
Member

reverts 7d71ad4

@amrbashir amrbashir requested a review from a team as a code owner June 17, 2023 12:37
@lucasfernog
Copy link
Member

No need for a change file since we didn't release yet @amrbashir and actually need to delete .changes/notification-sound.md.

@amrbashir
Copy link
Member Author

We did release it https://github.com/tauri-apps/plugins-workspace/releases/tag/notification-v2.0.0-alpha.1

lucasfernog
lucasfernog approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot covector never deletes the change files when we're in alpha :|

@lucasfernog lucasfernog merged commit c81dff2 into v2 Jun 18, 2023
@lucasfernog lucasfernog deleted the fix/revert-windows-notification-sound branch June 18, 2023 10:18
@github-actions github-actions bot mentioned this pull request Jun 18, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog