feat(updater): refactor and improvements #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
requested changes
Jun 17, 2023
lucasfernog
changed the title
lucasfernog
requested changes
Jun 20, 2023
plugins/updater/src/lib.rs
Outdated
| @@ -99,3 +141,7 @@ impl Builder { | |||
| .build() | |||
| } | |||
| } | |||
|
|
|||
| pub fn init<R: Runtime>() -> TauriPlugin<R, Config> { | |||
There was a problem hiding this comment.
So far we never exposed an init function when we have a Builder.. I feel it hides that API and could confuse the user IMO.
There was a problem hiding this comment.
Pushed a change to remove it.
There was a problem hiding this comment.
I feel like most users won't configure the plugin and just plug it and forget about it and the init function has a nicer syntax that I don't really think we should give that up.
This was referenced Jun 26, 2023
lucasfernog
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs tauri-apps/tauri#7174 and [email protected]