-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): refactor and improvements #428
Conversation
We need to keep client options somehow though. interface ClientOptions {
/**
* Defines the maximum number of redirects the client should follow.
* If set to 0, no redirects will be followed.
*/
maxRedirections?: number;
connectTimeout?: number | Duration;
} |
yeah I think, I will add a function overload to take a 3rd argument for these options |
Sounds good. Could also add it to the second argument I think (along with body, headers etc right?). |
It could, I will have to test, but I think it makes sense to have it separated so it doesn't conflict with web spec at all now or in the future. |
I ended up extending the second argument. |
@lucasfernog @amrbashir Thanks to create plugin. We have use case where application needs to call self signed intranet api. Could we expand scope from |
@james138138 Please open another issue to discuss your feature. |
plugins/http/guest-js/index.ts
Outdated
} | ||
|
||
type Part = string | Uint8Array | FilePart<Uint8Array>; | ||
class TauriResponse extends Response { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we need to extend and override Response
methods? Was new Response(dataAsBytes)
not enough?
No description provided.