feat(window): add setEffects API
#392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
May 24, 2023
| @@ -71,6 +71,11 @@ pub fn run() { | |||
| .decorations(false); | |||
| } | |||
|
|
|||
| #[cfg(target_os = "macos")] | |||
There was a problem hiding this comment.
Windows is already handled on the block above.
| * | ||
| * @since 2.0 | ||
| */ | ||
| async clearEffects(): Promise<void> { |
There was a problem hiding this comment.
Should we add an explicit clear effects method on tauri's side? Instead of relying on None?
There was a problem hiding this comment.
I think setting None is quite idiomatic for Rust isn't it? For JavaScript it looks weird..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref tauri-apps/tauri#6442
Needs alpha.10 :)