Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opener): use the correct packagename in OpenerPlugin.kt #2207

Merged

Conversation

universalappfactory
Copy link
Contributor

The packagename in OpenerPlugin.kt was set to 'package app.tauri.shell' which leads to an ClassNotFoundException when using android as the PLUGIN_IDENTIFIER in lib.rs is set to app.tauri.opener.

I fixed the packagename according to the value in lib.rs (app.tauri.opener)

@universalappfactory universalappfactory requested a review from a team as a code owner December 14, 2024 09:40
Copy link
Contributor

github-actions bot commented Dec 14, 2024

Package Changes Through e0d1227

There are 2 changes which include opener with patch, opener-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.10 2.0.11
api-example-js 2.0.7 2.0.8
opener 2.2.1 2.2.2
opener-js 2.2.1 2.2.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a change file in .changes directory?

@universalappfactory
Copy link
Contributor Author

yes sure, i added a changes file.
Sorry, I just missed that it's required and thank's for the great work.

amrbashir
amrbashir previously approved these changes Dec 14, 2024
@amrbashir
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants