-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fs): add the size
method to get the size of a file or directory
#2095
Conversation
size
method to get the size of a file or directory.size
method to get the size of a file or directory
Package Changes Through 7709f2bThere are 16 changes which include fs with minor, upload with minor, upload-js with minor, deep-link with patch, deep-link-js with patch, persisted-scope with minor, log-plugin with patch, log-js with patch, fs-js with patch, http with patch, localhost with minor, opener with major, opener-js with major, positioner-js with minor, positioner with minor, sql with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! just a few small thinks. Also, we'll need a changefile like https://github.com/tauri-apps/plugins-workspace/blob/v2/.changes/fix-fs-scope-escape-paths.md
Thank you for your guidance, I've revised it, and you can look at it again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review the rest later, I'm just on a phone rn
the errors should be gone once you add the command to the invoke_handler list https://github.com/ayangweb/plugins-workspace/blob/fs-size/plugins/fs/src/lib.rs#L396 |
ok, I added it! |
looks like you also need to run |
Okay, I executed and submitted it! |
@FabianLars Help me refine it a bit more, thanks!