-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upload): add progressTotal
to event payload
#2033
Conversation
This is not a bug and has always been the expected behavior. (Expected from us at least, there were quite a few users confused by this) Since we're now keeping track of much more data than before the transfer_speed update i wouldn't mind adding a new field for this (keeping progress to represent the chunk size). In v3 we could consider renaming the progress field but now this would break too many apps. |
Package Changes Through 08013d4There are 7 changes which include upload with minor, upload-js with minor, deep-link with patch, deep-link-js with patch, fs with patch, fs-js with patch, localhost with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
How about adding a new field, for example, |
Well, i just said the same so yes, i agree :D i'd go for |
Thanks, could you also add a changefile like this one? https://github.com/VirtualPirate/plugins-workspace/blob/aa7b4c39ce1d3893f6fb72a06046f738f956fe52/.changes/add-transfer-speed.md |
It's probably more convenient that way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
thank you too |
progressTotal
to event payload
This pull request addresses an issue with progress tracking during downloads. Previously, progress was updated using
chunk.len()
, which only reflected the size of each individual chunk rather than the cumulative total.Changes:
Progress Calculation: Replaced
chunk.len()
withstats.total_transferred
for progress, ensuring it accurately reflects the cumulative download progress from start to end.TransferStats Update: Added
total_transferred
toTransferStats
to maintain an ongoing count of all transferred bytes without resetting per granularity interval.