Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use _ as word boundary in IIFE var names #1630

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix: use _ as word boundary in IIFE var names #1630

merged 3 commits into from
Aug 7, 2024

Conversation

FabianLars
Copy link
Member

fixes #1614

@FabianLars FabianLars requested a review from a team as a code owner August 7, 2024 12:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Package Changes Through e82d2e7

There are 5 changes which include barcode-scanner with prerelease, clipboard-manager with prerelease, deep-link with prerelease, global-shortcut with prerelease, window-state with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-beta.17 2.0.0-rc.0
barcode-scanner 2.0.0-rc.0 2.0.0-rc.1
clipboard-manager 2.0.0-rc.0 2.0.0-rc.1
deep-link 2.0.0-rc.0 2.0.0-rc.1
global-shortcut 2.0.0-rc.0 2.0.0-rc.1
window-state 2.0.0-rc.0 2.0.0-rc.1

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

git stash is not what it used to be 😭 (yes, i was working on the sql plugin a few days ago)

@FabianLars
Copy link
Member Author

Running git revert twice can detect whether it reverts a revert commit, that's insane 🤯

@FabianLars FabianLars merged commit 2c00c02 into v2 Aug 7, 2024
4 checks passed
@FabianLars FabianLars deleted the fix/iife-name branch August 7, 2024 12:14
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
Merged
@FabianLars FabianLars mentioned this pull request Aug 16, 2024
Closed
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
@FabianLars @Sir-Thom
fix: use _ as word boundary in IIFE var names (tauri-apps#1630)
25dcbe3 
* fix: use `_` as word boundary in IIFE var names

* Revert "fix: use `_` as word boundary in IIFE var names"

This reverts commit 396ed3f.

* Reapply "fix: use `_` as word boundary in IIFE var names"

This reverts commit f31de7d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clipboard Manger is __TAURI_PLUGIN_CLIPBOARDMANAGER__ instead of __TAURI_PLUGIN_CLIPBOARD_MANAGER__
1 participant
@FabianLars