Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cargo package, publish without verification #1581

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Jul 24, 2024

Motivation

We no longer presume any value in publishing the .crate to the GitHub Release.

Approach

  • Removing this, and in turn, the need to compile and check before publishing.
  • I also merged the publish workflows as, with these changes, there was no need to maintain separate workflows.
  • Finally, I added a step in the workflow to sync the lock file. This should show up in the Version Packages PR now.

@jbolda jbolda requested a review from a team as a code owner July 24, 2024 04:05
Copy link
Contributor

github-actions bot commented Jul 24, 2024

Package Changes Through 0c2215b

There are 1 changes which include log-plugin with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-beta.14 2.0.0-beta.15
log-plugin 2.0.0-beta.8 2.0.0-beta.9

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

.changes/config.json Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 5ec3101 into v2 Jul 25, 2024
4 checks passed
@lucasfernog lucasfernog deleted the remove-publish-package-merge-workflows branch July 25, 2024 00:57
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
* remove cargo package, publish without verification

* remove custom publish with features, --no-verify should handle it now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants