Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change!(updater): disable zip feature by default #1521

Closed

Conversation

Legend-Master
Copy link
Contributor

As we made a new option in tauri CLI in tauri-apps/tauri#9883, I think we should remove zip from updater plugin's default features, and make people opt-in instead of opt-out

@Legend-Master Legend-Master requested a review from a team as a code owner July 6, 2024 01:56
@Legend-Master Legend-Master changed the title Disable zip feature by default for updater change(updater): disable zip feature by default Jul 6, 2024
@Legend-Master Legend-Master changed the title change(updater): disable zip feature by default change!(updater): disable zip feature by default Jul 6, 2024
@FabianLars
Copy link
Member

should probably be part of tauri migrate now that you mention it.

@Legend-Master
Copy link
Contributor Author

Made a PR

@amrbashir
Copy link
Member

This should wait until v3, just to give users (who wouldn't necessarily use tauri migrate) an easier upgrade.

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jul 6, 2024

I don't think this makes a huge difference as we have made this into a plugin, the user either has to use our cli's migrate or go and look up the updater plugin's docs/readme, and this is just an extra line (the user needs to learn what v1 compatible updater is anyway)

In the other hand, for people coming from v2 or started using v2 updaters, they'll need to do no default features which really isn't that great

@amrbashir
Copy link
Member

In the other hand, for people coming from v2 or started using v2 updaters, they'll need to do no default features which really isn't that great

That could be argued both ways.

In fact, I think it is better to opt-out of zip instead of opt-in as it allows more flexibility in terms of supporting more features and easier upgrade for current users. I am fine with making this opt-in in v3, because by then "easier upgrade for current users" won't factor in as much.

@Legend-Master
Copy link
Contributor Author

Alright, the zip crate without any compression enabled shouldn't be too big, I don't quite like it but I don't think I want to fight for it either, closing it for now and we can reopen it on v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants