Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use no default features on tauri #1402

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

Legend-Master
Copy link
Contributor

Use no default features on tauri for all plugins so that consumers can use default-features = false on tauri

@Legend-Master Legend-Master requested a review from a team as a code owner June 2, 2024 02:23
@Legend-Master
Copy link
Contributor Author

Needs tauri-apps/tauri#9954

@Legend-Master
Copy link
Contributor Author

Hmm, all the iOS tests are failing but they did fine in the tauri repo https://github.com/tauri-apps/tauri/actions/runs/9754721776/job/26922051410

@lucasfernog
Copy link
Member

Needs a Tauri patch unfortunately.

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Package Changes Through d05f9ba

There are 28 changes which include fs with prerelease, authenticator with prerelease, autostart with prerelease, barcode-scanner with prerelease, biometric with prerelease, cli with prerelease, clipboard-manager with prerelease, deep-link with prerelease, dialog with prerelease, global-shortcut with prerelease, http with prerelease, localhost with prerelease, log-plugin with prerelease, nfc with prerelease, notification with prerelease, os with prerelease, persisted-scope with prerelease, positioner with prerelease, process with prerelease, shell with prerelease, single-instance with prerelease, sql with prerelease, store with prerelease, stronghold with prerelease, updater with prerelease, upload with prerelease, websocket with prerelease, window-state with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.0-beta.15 2.0.0-beta.16
authenticator 2.0.0-beta.9 2.0.0-beta.10
autostart 2.0.0-beta.9 2.0.0-beta.10
barcode-scanner 2.0.0-beta.9 2.0.0-beta.10
biometric 2.0.0-beta.8 2.0.0-beta.9
cli 2.0.0-beta.8 2.0.0-beta.9
clipboard-manager 2.1.0-beta.6 2.1.0-beta.7
deep-link 2.0.0-beta.9 2.0.0-beta.10
fs 2.0.0-beta.11 2.0.0-beta.12
dialog 2.0.0-beta.11 2.0.0-beta.12
global-shortcut 2.0.0-beta.8 2.0.0-beta.9
http 2.0.0-beta.12 2.0.0-beta.13
localhost 2.0.0-beta.8 2.0.0-beta.9
log-plugin 2.0.0-beta.9 2.0.0-beta.10
nfc 2.0.0-beta.8 2.0.0-beta.9
notification 2.0.0-beta.11 2.0.0-beta.12
os 2.0.0-beta.8 2.0.0-beta.9
persisted-scope 2.0.0-beta.11 2.0.0-beta.12
positioner 2.0.0-beta.9 2.0.0-beta.10
process 2.0.0-beta.8 2.0.0-beta.9
shell 2.0.0-beta.9 2.0.0-beta.10
single-instance 2.0.0-beta.11 2.0.0-beta.12
sql 2.0.0-beta.10 2.0.0-beta.11
store 2.0.0-beta.10 2.0.0-beta.11
stronghold 2.0.0-beta.8 2.0.0-beta.9
updater 2.0.0-beta.11 2.0.0-beta.12
upload 2.0.0-beta.9 2.0.0-beta.10
websocket 2.0.0-beta.9 2.0.0-beta.10
window-state 2.0.0-beta.11 2.0.0-beta.12

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Is the iOS wry feature still required with Lucas's PR merged and released?

@Legend-Master
Copy link
Contributor Author

I think so, Lucas's change file said

Move PluginApi::register_ios_plugin behind the wry Cargo feature as Webview::with_webview is only available when that feature is enabled.

@FabianLars FabianLars merged commit e847ced into tauri-apps:v2 Jul 30, 2024
136 of 138 checks passed
@Legend-Master Legend-Master deleted the no-default-tauri-features branch July 30, 2024 09:26
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
* Use no default feature on tauri

* Add change file

* typo

* Revert lock file conflict

* Use wry on iOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants