-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): enable cookies and set origin header #1192
Conversation
Do we need to make the origin configurable (including omitting it)? Or should we wait and see if users request that? |
I'd probably wait and see if there is any use-case to omitting/modifying it |
afaik just the feature flag alone doesn't do much, we have to enable cookie support on the builder too. I assume that we'll need to store our own cookie store/jar in a State to share cookies between fetch calls because we don't reuse clients anymore. |
I think so, let me add that real quick |
should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i didn't test it)
@amrbashir can you pls fix the error :
It's a very small error ! but for this I can't compile the code of my app! |
@ToxicalNoob3062 this is already fixed in #1325 and will be available in the next release, for now, ping |
Welp, 8 hours after release: #1389 |
oh well, gotta open another PR |
closes #1167