Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): enhance scope URL matching via urlpattern #1030

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

lucasfernog
Copy link
Member

This PR enhances the HTTP scope matching by using urlpattern instead of glob. It is safer and easier to understand, following best practices for matching URLs with wildcards. glob wasn't meant to be used for URLs anyway :)

@lucasfernog lucasfernog requested a review from a team as a code owner March 5, 2024 23:52
@lucasfernog lucasfernog merged commit ac520a2 into v2 Mar 6, 2024
14 checks passed
@lucasfernog lucasfernog deleted the feat/enhance-http-scope-check branch March 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants