Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose FilePath::path to public #1726

Closed
anatawa12 opened this issue Sep 3, 2024 · 0 comments · Fixed by #1727
Closed

expose FilePath::path to public #1726

anatawa12 opened this issue Sep 3, 2024 · 0 comments · Fixed by #1727
Labels
enhancement New feature or request plugin: fs Includes former "fs-extra" and "fs-watch" plugins

Comments

@anatawa12
Copy link

I want tauri plugin dialog to expose FilePath::path to public?

I think it might be good to have FilePath::into_path to avoid copying PathBuf
@FabianLars FabianLars added enhancement New feature or request plugin: fs Includes former "fs-extra" and "fs-watch" plugins labels Sep 3, 2024
amrbashir added a commit that referenced this issue Sep 3, 2024
@amrbashir
refactor: add methods and implement traits for FilePath and `SafeFi…
0c85ec3 
…lePath`

closes #1726
@amrbashir amrbashir mentioned this issue Sep 3, 2024
Merged
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this issue Oct 22, 2024
@amrbashir @Sir-Thom
refactor: add methods and implement traits for FilePath and `SafeFi…
255a4f3 
…lePath` (tauri-apps#1727)

* refactor: add methods and implement traits for `FilePath` and `SafeFilePath`

closes tauri-apps#1726

* clippy

* path -> as_path

* fix prettierignore

* Discard changes to Cargo.lock

* Discard changes to Cargo.toml

* update tauri deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request plugin: fs Includes former "fs-extra" and "fs-watch" plugins
Projects
None yet
Milestone
No milestone
2 participants
@anatawa12 @FabianLars