Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should FileResponse be #[non_exhaustive]? #1623

Closed
anatawa12 opened this issue Aug 3, 2024 · 3 comments · Fixed by #1660
Closed

Should FileResponse be #[non_exhaustive]? #1623

anatawa12 opened this issue Aug 3, 2024 · 3 comments · Fixed by #1660
Labels
plugin: dialog question Further information is requested

Comments

@anatawa12
Copy link

Currently tauri_plugin_dialog::FileResponse is not #[non_exhaustive] but this means adding fields to tauri_plugin_dialog::FileResponse is braking changes.

Is this fine?
@anatawa12
Copy link
Author

FileResponse was exported in #837 without discussion about non_exhaustive so I feel it might not be expected.

@FabianLars FabianLars added question Further information is requested plugin: fs Includes former "fs-extra" and "fs-watch" plugins labels Aug 3, 2024
@anatawa12
Copy link
Author

This is about plugin: dialog, not plugin: fs

@FabianLars
Copy link
Member

whoops

@FabianLars FabianLars added plugin: dialog and removed plugin: fs Includes former "fs-extra" and "fs-watch" plugins labels Aug 5, 2024
amrbashir added a commit that referenced this issue Aug 13, 2024
@amrbashir
recator(dialog): mark FileResponse as #[non_exhaustive]
2a3a57f 
closes #1623
@amrbashir amrbashir mentioned this issue Aug 13, 2024
Merged
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this issue Oct 22, 2024
@amrbashir @Sir-Thom
refacator(dialog): mark FileResponse as #[non_exhaustive] (tauri-…
e186bf9 
…apps#1660)

* recator(dialog): mark `FileResponse` as `#[non_exhaustive]`

closes tauri-apps#1623

* change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin: dialog question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refacator(dialog): mark FileResponse as #[non_exhaustive] tauri-apps/plugins-workspace
2 participants
@anatawa12 @FabianLars