fix: fix plugins/fs infinite loop on autoregen (#1029)

* Created safety check for redundant autogenerations * Accounted for empty file case, added .changes file * Update plugins/fs/build.rs
tauri-apps · Mar 6, 2024 · 7358102 · 7358102
1 parent ac520a2
commit 7358102
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changes/file-autogen-fix.md b/.changes/file-autogen-fix.md
@@ -0,0 +1,6 @@
+---
+"fs": patch
+"fs-js": patch
+---
+
+Fix infinite loop on cargo build operations
diff --git a/plugins/fs/build.rs b/plugins/fs/build.rs
@@ -154,8 +154,11 @@ permissions = [
 ]"###
         );
 
-        std::fs::write(base_dirs.join(format!("{lower}.toml")), toml)
-            .unwrap_or_else(|e| panic!("unable to autogenerate ${upper}: {e}"));
+        let permission_path = base_dirs.join(format!("{lower}.toml"));
+        if toml != std::fs::read_to_string(&permission_path).unwrap_or_default() {
+            std::fs::write(permission_path, toml)
+                .unwrap_or_else(|e| panic!("unable to autogenerate ${lower}: {e}"));
+        }
     }
 
     tauri_plugin::Builder::new(COMMANDS)