Add an extra key for HardButton. / Rename "Playfield" to "Ring" #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"field-overlay" is now renamed to "ring-overlay" with this change, if you were working on a skin then please rename this file.
While I did not agree to add the extra key into the ruleset, people kept pushing me to add in the extra key. The new default for this key is "Left Shift" and "Space", since those two seems to be the most prominent keys used in Tau.
naoei
changed the title
LumpBloom7
requested changes
May 3, 2021
LumpBloom7
requested changes
May 3, 2021
LumpBloom7
reviewed
May 13, 2021
There was a problem hiding this comment.
When testing this change for regressions, I noticed that it is possible to tap the Left and Right button using multiple input methods. This essentially gives players 4 usable keys for streams and such. Do we want this to be a possibility?
If not, then this should be reverted, and the extra key will be given its own action, which we can then plug into the replay system.
LumpBloom7
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "Playfield" -> "Ring" for skinning.
"field-overlay" is now renamed to "ring-overlay" with this change, if you were working on a skin then please rename this file.
Add an extra key for HardButton.
While I did not agree to add the extra key into the ruleset, people kept pushing me to add in the extra key.
The new default for this key is "Left Shift" and "Space", since those two seems to be the most prominent keys used in Tau.
don't know why these two commits were merged when i created this pull request...