Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hard beat #108

Closed
wants to merge 12 commits into from
Closed

Implement Hard beat #108

wants to merge 12 commits into from

Conversation

LumpBloom7
Copy link
Collaborator

@LumpBloom7 LumpBloom7 commented Jul 17, 2020

Implements #5

Depends on #107

This PR implements the Hard Beat as mentioned in the issue. The Hitobject only checks for hit timing, as there isn't a need to validate the cursor position

Demo video: https://youtu.be/4MAqM9ih3Uo

Copy link
Member

@naoei naoei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good from the demo video you've sent over. i'll adjust some animations to make it more satisfying to hit.

@LumpBloom7
Copy link
Collaborator Author

LumpBloom7 commented Jul 18, 2020

If you happen to have a concept, send it over, perhaps I can implement that.

@LumpBloom7 LumpBloom7 marked this pull request as ready for review July 18, 2020 08:20
@naoei naoei mentioned this pull request Jul 19, 2020
@naoei
Copy link
Member

naoei commented Jul 19, 2020

Moved to #109

@naoei naoei closed this Jul 19, 2020
@LumpBloom7 LumpBloom7 deleted the HardBeat branch July 19, 2020 05:18
LumpBloom7 added a commit that referenced this pull request Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants