Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Github Issue templates into forms #361 #400

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

plon-Susk7
Copy link
Contributor


name: Feature Enhancement
about: turning github issue templates into forms
title: Turn Github Issue templates into forms #361
labels: enhancement
assignees: ''


Describe the PR
made yaml files for issue templates and deleted old markdown template files

Steps to test the PR
Not sure how to test my PR, but the official syntax was followed.

Expected behavior
The issue template now will be more user friendly and easy to fill.

Screenshots
N/A

Additional context
N/A

@ghost
Copy link

ghost commented Oct 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@plon-Susk7
Copy link
Contributor Author

@dennyabrain @aatmanvaidya please review my PR, thanks :)

@aatmanvaidya aatmanvaidya self-requested a review October 10, 2023 12:54
@plon-Susk7
Copy link
Contributor Author

@aatmanvaidya
Copy link
Collaborator

@plon-Susk7 thank you for the work, give us some time to review, we will get back to you!

@plon-Susk7
Copy link
Contributor Author

Sure, thanks @aatmanvaidya

@aatmanvaidya
Copy link
Collaborator

Hi @plon-Susk7 , gave it a test by creating issues on your demo github repo

some suggestions

in the Issue: Feature Request

  1. Can you make the question - "Describe alternatives you've considered" not compulsory, because it not necessarily everyone would have considered some alternative solution.

in the Issue: Bug Report

  1. In the question - "What browsers are you seeing the problem on?", can you also add a dropdown option called "Other", because it might happen (although highly unlikely), that some users are using other browsers that what is there in the options.
  2. Just curious, why is the last question about accepting the Code of Conduct? Is it automatically there by GitHub forms or did you add it?
  3. Once I submit the bug report issue, why does 1 task done bubble pop-up, like in the image below. Again just curious, it might GitHub automatically adding that, I am just thinking out loud.
    Screenshot from 2023-10-10 20-18-23

In the Issue: QA Test Checklist

  1. Can we add just like a text box, where a user can also request QA testing for something else then a feature, it could be say a problem in viewing the image logo in different browsers, it could be some text issue as well, we never know.

These are just my thoughts, @dennyabrain please feel free to correct me!

@plon-Susk7 good work!

@plon-Susk7
Copy link
Contributor Author

Hey @aatmanvaidya ,

Feature Request : Done

Bug Report:

  1. Done
  2. Removed Code of conduct, it was there in the documentation I forgot to remove it.
  3. It's a default thing by github as I have added no extra code for it.

QA Test Checklist: Could you please elaborate it a more.

@plon-Susk7
Copy link
Contributor Author

Nevermind got it @aatmanvaidya . Pushing my changes to both repo.

@aatmanvaidya
Copy link
Collaborator

great

also, @plon-Susk7 , one small change is Issue: Feature request

In the begining, this text appreas - Thanks for taking the time to fill out this bug report!, can we remove it? as users might mis-understand the feature and the bug.
Apologies for being this nitpicky about things

@plon-Susk7
Copy link
Contributor Author

Hi @aatmanvaidya I have pushed the changes. Thanks for the feedback.

@aatmanvaidya
Copy link
Collaborator

thanks @plon-Susk7

@dennyabrain tested this PR, things look good now, its a green light to merge from my side.

@aatmanvaidya
Copy link
Collaborator

Hi @plon-Susk7 , some changes to the Issue: Bug Report are required.

As you can see in the image below.

Screenshot from 2023-10-11 10-51-23

In the placeholder text in Desktop and Smartphone which says "OS: [e.g iOS] is not proper, as it says the same for Desktop, so we might have to change that

So since, we already have a drop down for the browser - What browsers are you seeing the problem on?
Can we create a similar one for devices, so the question becomes - "Which operating system are you on?" and the options will be - Windows, MacOS, Linux, Android, iOS

and then we can have a text box asking more information about their system setup, something called - "More information about your setup"

@plon-Susk7
Copy link
Contributor Author

plon-Susk7 commented Oct 11, 2023

Hi @aatmanvaidya, I have pushed the changes to both repos.

@aatmanvaidya
Copy link
Collaborator

great

@dennyabrain please suggest any more changes if required.

@dennyabrain
Copy link
Contributor

lgtm. merging.

@dennyabrain dennyabrain linked an issue Oct 11, 2023 that may be closed by this pull request
@dennyabrain dennyabrain merged commit 9efff34 into tattle-made:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn Github Issue templates into forms
3 participants