Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Uli slur redaction for general websites #299

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix Uli slur redaction for general websites #299

merged 1 commit into from
Jul 12, 2023

Conversation

duggalsu
Copy link
Contributor

  • Fixed Uli site rendering issues
  • Fixed dynamic page loading issues
  • Updated update-browserslist-db@latest

Edge case handling

textContent gets the content of all elements, including <script> and <style> elements. In contrast, innerText only shows "human-readable" elements.

@duggalsu
Fix Uli slur redaction for general websites
4c44cca 
- Fixed Uli site rendering issues
- Fixed dynamic page loading issues
- Updated update-browserslist-db@latest
@dennyabrain dennyabrain self-requested a review July 12, 2023 10:50
@dennyabrain dennyabrain marked this pull request as draft July 12, 2023 10:50
@dennyabrain dennyabrain linked an issue Jul 12, 2023 that may be closed by this pull request
Expand Slur redaction feature to more websites #254
Closed
@dennyabrain dennyabrain marked this pull request as ready for review July 12, 2023 10:51
@dennyabrain dennyabrain merged commit 58dbaeb into tattle-made:main Jul 12, 2023
@dennyabrain dennyabrain added level:feature An issue that describes a feature (initiative>feature>ticket) level:ticket An issue that describes a ticket (initiative>feature>ticket) labels Jul 17, 2023
@duggalsu duggalsu mentioned this pull request Jul 19, 2023
Closed
@duggalsu duggalsu deleted the expand_slur_redaction branch November 29, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennyabrain dennyabrain Awaiting requested review from dennyabrain

Assignees

@duggalsu duggalsu

Labels
level:feature An issue that describes a feature (initiative>feature>ticket) level:ticket An issue that describes a ticket (initiative>feature>ticket)
Projects
No open projects
2023 Q3 Planner
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand Slur redaction feature to more websites
2 participants
@duggalsu @dennyabrain