Virtualized the destructors for the Extractor base classes.

I'm not sure this is really necessary as we're not calling the destructors through the base pointers, but better safe than sorry to avoid memory leaks.
tatami-inc · May 13, 2024 · 07fa357 · 07fa357
1 parent 6551664
commit 07fa357
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/include/tatami_chunked/CustomDenseChunkedMatrix.hpp b/include/tatami_chunked/CustomDenseChunkedMatrix.hpp
@@ -78,7 +78,7 @@ struct DenseBaseSolo {
         final_solo(factory.create())
     {}
 
-    ~DenseBaseSolo() = default;
+    virtual ~DenseBaseSolo() = default;
 
 protected:
     template<typename ... Args_>
@@ -112,7 +112,7 @@ struct DenseBaseMyopic {
         cache(max_slabs_in_cache)
     {}
 
-    ~DenseBaseMyopic() = default;
+    virtual ~DenseBaseMyopic() = default;
 
 protected:
     template<typename ... Args_>
@@ -143,7 +143,7 @@ struct DenseBaseOracular {
         cache(std::move(ora), max_slabs_in_cache)
     {}
 
-    ~DenseBaseOracular() = default;
+    virtual ~DenseBaseOracular() = default;
 
 protected:
     template<typename ... Args_>

diff --git a/include/tatami_chunked/CustomSparseChunkedMatrix.hpp b/include/tatami_chunked/CustomSparseChunkedMatrix.hpp
@@ -84,7 +84,7 @@ struct SparseBaseSolo {
         final_solo(factory.create())
     {}
 
-    ~SparseBaseSolo() = default;
+    virtual ~SparseBaseSolo() = default;
 
 protected:
     template<typename ... Args_>
@@ -120,7 +120,7 @@ struct SparseBaseMyopic {
         cache(max_slabs_in_cache) 
     {}
 
-    ~SparseBaseMyopic() = default;
+    virtual ~SparseBaseMyopic() = default;
 
 protected:
     template<typename ... Args_>
@@ -153,7 +153,7 @@ struct SparseBaseOracular {
         cache(std::move(ora), max_slabs_in_cache) 
     {}
 
-    ~SparseBaseOracular() = default;
+    virtual ~SparseBaseOracular() = default;
 
 protected:
     template<typename ... Args_>