Improve handling of isometric expansion when collapsing sparsity. #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several decisions that need to be made depending on:
The operation always needs to define
dense()
methods for a pointer with block and index extraction.If either of 1 or 2 is true, the operation should define a
dense()
method that takes aSparseRange
, and asparse()
method that takes aSparseRange
.If 3 is false, we call the
dense()
methods for a pointer with block and index extraction.If 3 is true and 1 is true, we call the
sparse()
method (even if dense output was requested).If 3 is true and 1 is false and 2 is true, we call
dense()
on theSparseRange
.If 3 is true and 1 is false and 2 is false, we call
dense()
on the pointers.