Add documentation page for MAX31855 thermocouple amplifier and link from various other locations. #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfickett
commented
Dec 11, 2023
barbudor
requested changes
Dec 17, 2023
docs/BUILDS.md
Outdated
| @@ -15,7 +15,7 @@ Note: `minimal` variant is not listed as it shouldn't be used outside of the [up | |||
| | USE_DOMOTICZ | - | x / x | x | x | x | - | | |||
| | USE_HOME_ASSISTANT | - | - / - | - | - | - | - | | |||
| | USE_TASMOTA_DISCOVERY | x | x / x | x | x | x | x | | |||
| | USE_MQTT_TLS* | - | - / x | - | - | - | - | | |||
| | USE_MQTT_TLS | - | - / x | - | - | - | - | USE_MQTT_TLS is enabled by default in every ESP32 variants | |||
There was a problem hiding this comment.
Please remove any changes from BUILDS.md
BUILDS.md and I2CDEVICES.md are actually automatically copied from Tasmota repo and should not be edited in the docs repo
To update them, please fill a PR on arendst/Tasmota
Thanks
There was a problem hiding this comment.
Got it, reverted BUILDS and I2CDEVICES. Since I added links from a couple other locations I probably will just leave those as-is, but good to know where they come from.
markfickett
force-pushed
the
mfickett/add-MAX31855
branch
from
4954727 to
45ddd73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved the
USE_MQTT_TLScomment inline to the table, since the lone asterisk was making formatting off in my editor and it's only referenced in one place.