Refaсtored process manager. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Kirilin <[email protected]>
Signed-off-by: Pavel Kirilin <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #64 +/- ##
===========================================
- Coverage 63.73% 61.08% -2.66%
===========================================
Files 36 37 +1
Lines 899 938 +39
===========================================
Hits 573 573
- Misses 326 365 +39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chandr-andr
approved these changes
Mar 19, 2023
booqoffsky
reviewed
Mar 19, 2023
Signed-off-by: Pavel Kirilin <[email protected]>
Signed-off-by: Pavel Kirilin <[email protected]>
|
A W E S O M E |
booqoffsky
approved these changes
Mar 19, 2023
oromogans
approved these changes
Mar 21, 2023
Signed-off-by: Pavel Kirilin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored process management for workers.
Now we use ublocking event queue and a big fat custom event loop.
It closes #63. Worker hanged, because observer thread was blocking on event queue until all events are processed. To solve this problem, I had to rewrite the whole process management logic from scratch.