fix: Fix the prefix used to delete from s3 when unpublishing packages (…

…verdaccio#2243)
taskforcesh · May 12, 2021 · 6b1a28d · 6b1a28d
1 parent a54c18c
commit 6b1a28d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/calm-pants-impress.md b/.changeset/calm-pants-impress.md
@@ -0,0 +1,5 @@
+---
+'verdaccio-aws-s3-storage': patch
+---
+
+Fix the prefix used to delete from s3 when unpublishing packages
diff --git a/packages/plugins/aws-storage/src/s3PackageManager.ts b/packages/plugins/aws-storage/src/s3PackageManager.ts
@@ -172,7 +172,7 @@ export default class S3PackageManager implements ILocalPackageManager {
       this.s3,
       {
         Bucket: this.config.bucket,
-        Prefix: `${this.packagePath}`,
+        Prefix: addTrailingSlash(this.packagePath),
       },
       function (err) {
         if (err && is404Error(err as VerdaccioError)) {

diff --git a/packages/plugins/aws-storage/tests/s3PackageManagerMockedS3.test.ts b/packages/plugins/aws-storage/tests/s3PackageManagerMockedS3.test.ts
@@ -231,7 +231,7 @@ describe('S3PackageManager with mocked s3', function () {
       expect(mockListObject).toHaveBeenCalledWith(
         {
           Bucket: 'test-bucket',
-          Prefix: 'testKeyPrefix/@company/test-package',
+          Prefix: 'testKeyPrefix/@company/test-package/',
         },
         expect.any(Function)
       );
@@ -270,7 +270,7 @@ describe('S3PackageManager with mocked s3', function () {
       expect(mockListObject).toHaveBeenCalledWith(
         {
           Bucket: 'test-bucket',
-          Prefix: 'testKeyPrefix/customFolder/@company/test-package',
+          Prefix: 'testKeyPrefix/customFolder/@company/test-package/',
         },
         expect.any(Function)
       );