fix(worker): catch connection error when moveToActive #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Dec 5, 2024
| @@ -516,15 +516,15 @@ describe('Job Scheduler', function () { | |||
| const delay = 5 * ONE_SECOND + 500; | |||
|
|
|||
| const worker = new Worker( | |||
| queueName, | |||
| queueName2, | |||
There was a problem hiding this comment.
this test case must used queueName2 in order to point to the same queue that has remove option
roggervalf
commented
Dec 5, 2024
| @@ -1211,7 +1211,7 @@ describe('Job Scheduler', function () { | |||
| }); | |||
|
|
|||
| it('should repeat 7:th day every month at 9:25', async function () { | |||
| this.timeout(8000); | |||
| this.timeout(12000); | |||
There was a problem hiding this comment.
flaky test sometimes because of timing, when a disconnection happens when moving job to active
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
## [5.31.2](v5.31.1...v5.31.2) (2024-12-06) ### Bug Fixes * **worker:** catch connection error when moveToActive is called ([#2952](#2952)) ([544fc7c](544fc7c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when disconnection happens when moveToActive is called, connection errors are console logged because we are not executing this call in try block