fear: add onChildFailure option #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Aug 17, 2024
| @@ -126,12 +114,13 @@ if rcall("EXISTS", jobIdKey) == 1 then -- // Make sure job exists | |||
| -- 2) move the job Id to parent "processed" set | |||
| -- 3) push the results into parent "results" list | |||
| -- 4) if parent's dependencies is empty, then move parent to "wait/paused". Note it may be a different queue!. | |||
| if parentId == "" and parentKey ~= "" then | |||
| parentId = getJobIdFromKey(parentKey) | |||
| parentQueueKey = getJobKeyPrefix(parentKey, ":" .. parentId) | |||
There was a problem hiding this comment.
this logic is not needed anymore as all parent data is saved in parent attribute
roggervalf
commented
Aug 17, 2024
| local function moveParentIfNeeded(parentData, parentKey, jobIdKey, | ||
| failedReason, timestamp) | ||
| if parentData['ocf'] then | ||
| if parentData['ocf'] == 'fail' then |
There was a problem hiding this comment.
we can possible have a mapping like:
fail: f
ignore: i
remove: r
wait: w
that way we can only compare 1 character
roggervalf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.