fix(python): make sure json.dumps return JSON compliant JSON (python) #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @saulane, thanks for this fix. Could you also add a test case where it would fail without this change? |
saulane
force-pushed
the
json-compliant-python
branch
from
ed428de to
29f9a08
Compare
saulane
force-pushed
the
json-compliant-python
branch
from
29f9a08 to
a58e6f0
Compare
@roggervalf done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python version can return a non-JSON-compliant value to Redis, which breaks when trying to retrieve the value using the Node version of the library.
By adding "allow_nan=True", we raise an error before sending the value to Redis, which prevents having bad JSON in the job's return value.