Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): set blockTimeout as 0.001 when reach the time to get delayed jobs [python] #2478

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

roggervalf
Copy link
Collaborator

No description provided.

@roggervalf roggervalf merged commit b385034 into master Mar 19, 2024
11 checks passed
@roggervalf roggervalf deleted the fix-delayed-python branch March 19, 2024 05:06
@manast
Copy link
Contributor

manast commented Mar 19, 2024

I think we should document somewhere that 0.001 seconds which is 1 millisecond is chosen because the granularity of our timestamps are milliseconds. Obviously we can still process much faster than 1 job per millisecond but delays and rate limits will never work with more accuracy than 1ms... maybe I will write a blog post about it.

github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
## [5.4.4](v5.4.3...v5.4.4) (2024-03-21)

### Bug Fixes

* **queue:** use QueueOptions type in opts attribute ([#2481](#2481)) ([51a589f](51a589f))
* **worker:** set blockTimeout as 0.001 when reach the time to get delayed jobs [python] ([#2478](#2478)) ([b385034](b385034))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants