fix(python backoff): fix bug when using builtin backoff type #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a builtin backoff type is used, the lookup was expecting and object with a property type, but the passed value from the job is a dict. This fixes the lookup and adds a test for it.
roggervalf
reviewed
Nov 7, 2023
roggervalf
reviewed
Nov 7, 2023
Delay lookup from backoff was done using .delay, but backoff is a dict so needs to be done using .get
HalfdanJ
changed the title
The builtin strategy was not returned from lookup_strategy
|
I managed to get my local tests working, discovered another bug in the lookup code that i've fixed. The tests are now passing locally, so 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a builtin backoff type is used, the lookup was expecting and object with a property type, but the passed value from the job is a dict. This fixes the lookup and adds a test for it.
Before the fix, an exception would be thrown: