Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Batched unpack now uses range #2188

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

SemvandenBroek
Copy link
Contributor

The drain-4 command used in the queue.drain() function still used a non-batching variant of the unpack function in the removeZSetJobs.lua file. This resulted in the drain function failing when the unpack had too many values to unpack.

This PR adds a range to the unpack function so that it has to unpack fewer values for each batched iteration.

@SemvandenBroek SemvandenBroek changed the title Batched unpack now uses range fix:Batched unpack now uses range Sep 21, 2023
@manast
Copy link
Contributor

manast commented Sep 22, 2023

Good catch! thanks for the fix.

@manast manast merged commit b5e97f4 into taskforcesh:master Sep 22, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
## [4.11.4](v4.11.3...v4.11.4) (2023-09-22)

### Bug Fixes

* **queue:** batched unpack now uses range ([#2188](#2188)) ([b5e97f4](b5e97f4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants