Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid importing from '..' #2187

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Avoid importing from '..' #2187

merged 2 commits into from
Sep 21, 2023

Conversation

synchrone
Copy link
Contributor

Import commands from their originating module, not from a re-export module.

This is important for compatibility with import-in-the-middle and other import-altering code, otherwise this results in a partially-loaded module being passed into instrumentation code.

Import commands from their originating module, not from a re-export module.

This is important for compatibility with import-in-the-middle and other import-altering code, otherwise this results in a partially-loaded module being passed into instrumentation code.
@@ -1,7 +1,7 @@
import { ChildProcess, fork } from 'child_process';
import { Worker } from 'worker_threads';
import { AddressInfo, createServer } from 'net';
import { ChildCommand, ParentCommand } from '../';
import { ChildCommand, ParentCommand } from '../commands';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commands are our lua scripts

@roggervalf roggervalf merged commit bcc92fe into taskforcesh:master Sep 21, 2023
9 checks passed
@synchrone synchrone deleted the patch-1 branch September 21, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants