fix(worker): throw exception with NaN as concurrency #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Sep 17, 2023
src/classes/worker.ts
Outdated
| @@ -564,8 +568,6 @@ export class Worker< | |||
| if (!this.closing) { | |||
| await this.delay(); | |||
| } | |||
| } finally { | |||
| this.waiting = null; | |||
There was a problem hiding this comment.
What's behind this deleted line?
There was a problem hiding this comment.
that's a good question... must be the leftover of some testing I was doing.
roggervalf
approved these changes
Sep 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
## [4.11.2](v4.11.1...v4.11.2) (2023-09-20) ### Bug Fixes * **worker:** throw exception with NaN as concurrency ([#2184](#2184)) ([f36ac8b](f36ac8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got hinted that if you use NaN as a concurrency value the worker goes bananas. Here is a fix for it.