feat(sandboxed-job): add support for getChildrenValues #1417
+125
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything I can do to help get this merged? 😃 |
roggervalf
reviewed
Dec 13, 2022
| }; | ||
| }); | ||
|
|
||
| process.on('message', msgHandler); |
There was a problem hiding this comment.
we took a look but no sure if this is the best way to handle this case. We should revisit this pr
|
Any update on this one? |
|
Any update on this one? |
manast
reviewed
Aug 25, 2024
|
|
||
| process.on('message', msgHandler); | ||
|
|
||
| try { |
There was a problem hiding this comment.
most likely we do not need to swallow possible errors, instead the caller of getChildrenValues will need to handle it himself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @manast @roggervalf :D
Looking to get this feature added for sandboxed workers. The only part I'm not certain on is how you'd like this error to be handled, or if there is try/catch further up the chain so it's not needed here.
Fixes taskforcesh/bullmq-pro-support#21
Fixes #1306
Fixes #753