Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): catch connection error when moveToActive #2952

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

roggervalf
Copy link
Collaborator

when disconnection happens when moveToActive is called, connection errors are console logged because we are not executing this call in try block

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -516,15 +516,15 @@ describe('Job Scheduler', function () {
const delay = 5 * ONE_SECOND + 500;

const worker = new Worker(
queueName,
queueName2,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test case must used queueName2 in order to point to the same queue that has remove option

@@ -1211,7 +1211,7 @@ describe('Job Scheduler', function () {
});

it('should repeat 7:th day every month at 9:25', async function () {
this.timeout(8000);
this.timeout(12000);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flaky test sometimes because of timing, when a disconnection happens when moving job to active

@roggervalf roggervalf merged commit 544fc7c into master Dec 6, 2024
12 checks passed
@roggervalf roggervalf deleted the fix-catch-connection-error branch December 6, 2024 03:05
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
## [5.31.2](v5.31.1...v5.31.2) (2024-12-06)

### Bug Fixes

* **worker:** catch connection error when moveToActive is called ([#2952](#2952)) ([544fc7c](544fc7c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant