Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: look up action tasks by revision in fetch_graph_and_labels #589

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jcristau
Copy link
Contributor

Projects on github don't have a meaningful pushlog-id, so we don't use it in the index path for action tasks. When building the label-to-taskid mapping for a revision, look up action tasks in the index using the head_rev, where we can actually find them.

This can potentially do the wrong thing if a revision is pushed to two different branches, where we'd be mixing up the graphs, but we don't currently include the branch name in the index paths.

Projects on github don't have a meaningful pushlog-id, so we don't use
it in the index path for action tasks.  When building the
label-to-taskid mapping for a revision, look up action tasks in the
index using the head_rev, where we can actually find them.

This can potentially do the wrong thing if a revision is pushed to two
different branches, where we'd be mixing up the graphs, but we don't
currently include the branch name in the index paths.
parameters["project"],
parameters["head_rev"],
)
for task_id in set(list_tasks(pushlog_namespace) + list_tasks(rev_namespace)):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using set() to deduplicate, but I'm not sure if there's a different ordering from list_tasks that this should preserve?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure either.. It's probably fine?

@jcristau jcristau requested review from a team and ahal October 15, 2024 09:36
@jcristau jcristau marked this pull request as ready for review October 15, 2024 09:36
Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jcristau jcristau merged commit 2269a99 into taskcluster:main Oct 17, 2024
14 of 16 checks passed
@jcristau jcristau deleted the action-index-revision branch October 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants