Upstream some fixes in taskgraph.util.templates from gecko_taskgraph
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This can impact how `task-defaults` gets merged into each task definition. The default merge behaviour would mix the `by-<key>` key in with non-keyed-by configs. This is a bug and certainly not what the user would be expecting. It is possible that the user intended to mix two `by-<key>` configs together, but this case should be extremely rare. This is a port of the following `gecko_taskgraph` patch: https://hg.mozilla.org/mozilla-central/rev/0fe5ffc10ff8488d780c5c3cbcff1b43ca974cf7
ahal
added
the
BREAKING CHANGE
And use it in `util.templates.merge`. This is a port of the following patch in `gecko_taskgraph`: https://hg.mozilla.org/mozilla-central/rev/fa2cdac6989ac78d606d8f8adb10d826a6e50429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams a pair of changes to this file, one of which is breaking.