fix: support **kwargs in taskgraph.util.memoize #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this decorator only accepted `*args`, so any memoized function that used `**kwargs` could no longer be called via keyword arguments. This is handled by replacing our custom memoize implementation with the built-in `functools.lru_cache(maxsize=None)` which is equivalent.
ahal
commented
Apr 19, 2024
| @@ -167,7 +167,8 @@ def add_resource_monitor(config, tasks): | |||
| config.graph_config, task["worker-type"] | |||
| ) | |||
| # Normalise worker os so that linux-bitbar and similar use linux tools. | |||
| worker_os = worker_os.split("-")[0] | |||
| if worker_os: | |||
| worker_os = worker_os.split("-")[0] | |||
There was a problem hiding this comment.
I'm not really sure why, but for some reason switching to lru_cache causes Pyright to (rightly) flag this issue.
bhearsum
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this decorator only accepted
*args, so any memoized function that used**kwargscould no longer be called via keyword arguments.This is handled by replacing our custom memoize implementation with the built-in
functools.lru_cache(maxsize=None)which is equivalent.